Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] gh-91321: Fix test_cppext for C++03 (GH-93902) #93904

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

miss-islington
Copy link
Contributor

Don't build _testcppext.cpp with -Wzero-as-null-pointer-constant when
testing C++03: only use this compiler flag with C++11.
(cherry picked from commit a38c2a6)

Co-authored-by: Victor Stinner vstinner@python.org

Don't build _testcppext.cpp with -Wzero-as-null-pointer-constant when
testing C++03: only use this compiler flag with C++11.
(cherry picked from commit a38c2a6)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner
Copy link
Member

Ah, two CI checks failed with a network issue:

Could not connect to ppa.launchpad.net:80 (185.125.190.52), connection timed out

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ❌ .

@vstinner vstinner merged commit 62f72e4 into python:3.11 Jun 16, 2022
@miss-islington miss-islington deleted the backport-a38c2a6-3.11 branch June 16, 2022 13:17
@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants