Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] gh-93975: Nicer error reporting in test_venv (GH-93959) #94004

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jun 19, 2022

This change does three things:

  1. Extract a function for trapping output in subprocesses.
  2. Emit both stdout and stderr when encountering an error.
  3. Apply the change to ensurepip._uninstall check..
    (cherry picked from commit 6066f45)

Co-authored-by: Jason R. Coombs jaraco@jaraco.com

Automerge-Triggered-By: GH:jaraco

- gh-93957: Provide nicer error reporting from subprocesses in test_venv.EnsurePipTest.test_with_pip.
- Update changelog

This change does three things:

1. Extract a function for trapping output in subprocesses.
2. Emit both stdout and stderr when encountering an error.
3. Apply the change to `ensurepip._uninstall` check..
(cherry picked from commit 6066f45)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@jaraco jaraco requested a review from vsajip as a code owner June 19, 2022 16:26
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 19, 2022
@ambv ambv merged commit 259dd7e into 3.10 Jul 1, 2022
@ambv ambv deleted the backport-6066f45-3.10 branch July 1, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants