Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] GH-93516: Backport GH-93769 #94231

Merged
merged 6 commits into from
Jun 28, 2022

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Jun 24, 2022

Reduces the overhead of dispatching in DO_TRACING considerably.

My informal measures on the test program in #93516 (comment) show that this reduces execution time by about 10%

@pablogsal Should I regenerate the ABI for this PR?

@arhadthedev
Copy link
Member

arhadthedev commented Jun 24, 2022

Probably the issue should be renamed to ... Backport GH-93769 for a clickable number in https://github.com/python/cpython/commits/main (though, it's just a nitpick).

@markshannon markshannon changed the title [3.11] GH-93516: Backport 93769 [3.11] GH-93516: Backport GH-93769 Jun 24, 2022
@markshannon
Copy link
Member Author

@pablogsal I'd like to get this merged, as it will be needed for the backport of #94371

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@pablogsal
Copy link
Member

pablogsal commented Jun 28, 2022

@pablogsal Should I regenerate the ABI for this PR?

I can try to do it for you. Otherwise you can follow these instructions:

@pablogsal Should I regenerate the ABI for this PR?

@pablogsal
Copy link
Member

I cannot push to the PR, but you can copy this commit into yours if you want:

pablogsal@8380dd0

@markshannon
Copy link
Member Author

Hmm, I followed the instructions, yet a0ced71 is clearly different to pablogsal@8380dd0

@markshannon
Copy link
Member Author

I see, it is because of the assert changing the line numbers.
Why does an application binary interface include line numbers?

@pablogsal
Copy link
Member

Why does an application binary interface include line numbers?

Those are not taken into account when checking it. They just come from the DWARF if I am not mistaken

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@markshannon markshannon merged commit 3b4f5ed into python:3.11 Jun 28, 2022
@markshannon markshannon deleted the backport-93769 branch September 26, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants