-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.11] GH-93516: Backport GH-93769 #94231
Conversation
…ute it all the time when tracing.
…rsion of Python used.
Probably the issue should be renamed to |
@pablogsal I'd like to get this merged, as it will be needed for the backport of #94371 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
I can try to do it for you. Otherwise you can follow these instructions: |
I cannot push to the PR, but you can copy this commit into yours if you want: |
Hmm, I followed the instructions, yet a0ced71 is clearly different to pablogsal@8380dd0 |
I see, it is because of the assert changing the line numbers. |
Those are not taken into account when checking it. They just come from the DWARF if I am not mistaken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Reduces the overhead of dispatching in
DO_TRACING
considerably.My informal measures on the test program in #93516 (comment) show that this reduces execution time by about 10%
@pablogsal Should I regenerate the ABI for this PR?