-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-94857: fix test_io refleak #94858
Conversation
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit cda2f1dfaf42821c623fce9b30b775c7c898fd1c 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more possible refleaks in error paths. It would be better to incref encodings
eagerly and decref
it in error paths.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still leaks in three return
statements between lines 1260 and 1280.
Concur with @tiran. |
I have made the requested changes; please review again |
Thanks for making the requested changes! @tiran: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry @kumaraditya303, I had trouble checking out the |
Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
(cherry picked from commit 631160c) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
GH-94959 is a backport of this pull request to the 3.11 branch. |
Automerge-Triggered-By: GH:tiran