GH-94739: Mark stacks in exception handlers. #94958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
markshannon
commented
Jul 18, 2022
•
markshannon
commented
- Issue: cannot jump within exception handler in debugger #94739
markshannon
changed the title
iritkatriel
reviewed
Jul 18, 2022
Objects/frameobject.c
Outdated
| break; | ||
| case RETURN_VALUE: | ||
| assert(pop_value(next_stack) == 0); |
There was a problem hiding this comment.
Ah I see, you're asserting that there is just one item in the stack.
iritkatriel
reviewed
Jul 18, 2022
| int depth_and_lasti; | ||
| scan = parse_varint(scan, &depth_and_lasti); | ||
| int level = depth_and_lasti >> 1; | ||
| int lasti = depth_and_lasti & 1; |
There was a problem hiding this comment.
Would be good to assert here that start_offset and handler are in range.
iritkatriel
approved these changes
Jul 18, 2022
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry, @markshannon, I could not cleanly backport this to |
markshannon
added a commit
to faster-cpython/cpython
that referenced
this pull request
Jul 18, 2022
…frame.f_lineno in the debugger. (pythonGH-94958)
markshannon
added a commit
that referenced
this pull request
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.