Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-54781: Mention sqlite3 test relocation in What's New #95059

Closed
wants to merge 3 commits into from
Closed

gh-54781: Mention sqlite3 test relocation in What's New #95059

wants to merge 3 commits into from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 20, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting core review labels Jul 20, 2022
@erlend-aasland erlend-aasland mentioned this pull request Jul 20, 2022
Closed
@erlend-aasland erlend-aasland added the needs backport to 3.11 only security fixes label Jul 20, 2022
@erlend-aasland erlend-aasland mentioned this pull request Jul 20, 2022
Merged
@erlend-aasland erlend-aasland changed the title bpo-10572: Mention sqlite3 test relocation in What's New gh-54781: Mention sqlite3 test relocation in What's New Jul 20, 2022
@zware
Copy link
Member

zware commented Jul 20, 2022

I'm not sure this is really necessary. We haven't mentioned other, even major, test changes in whatsnew, and test code is explicitly documented as non-public.

@erlend-aasland
Copy link
Contributor Author

I'm not sure this is really necessary. We haven't mentioned other, even major, test changes in whatsnew, and test code is explicitly documented as non-public.

Right, thanks for the historical context. If so, I believe it is better to close this PR.

@erlend-aasland erlend-aasland added pending The issue will be closed if no feedback is provided DO-NOT-MERGE labels Jul 20, 2022
@terryjreedy
Copy link
Member

The changelog has a Tests section. If there is really a policy against mentioning anything about tests in What's New, I won't argue for this.

@zware
Copy link
Member

zware commented Jul 20, 2022

The changelog has a Tests section. If there is really a policy against mentioning anything about tests in What's New, I won't argue for this.

A mention in NEWS certainly makes sense, but I don't think it's worth an entry in whatsnew.

@erlend-aasland
Copy link
Contributor Author

A mention in NEWS certainly makes sense, but I don't think it's worth an entry in whatsnew.

"No sweat, I'll make him into a disciple." 🎨 🖌️

@erlend-aasland erlend-aasland removed needs backport to 3.11 only security fixes pending The issue will be closed if no feedback is provided labels Jul 20, 2022
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jul 20, 2022 •
edited
Loading

I'll create a new PR against 3.11 for the NEWS entry, then. UPDATE:

@erlend-aasland erlend-aasland deleted the mention-sqlite-test-move branch July 20, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
DO-NOT-MERGE docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @zware @terryjreedy @bedevere-bot