Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95335: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly #95107

Merged
merged 11 commits into from
Jul 26, 2022
Merged

gh-95335: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly #95107

merged 11 commits into from
Jul 26, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jul 21, 2022 •
edited
Loading

This further decouples the compiler struct from parts of the compilation process, and in particular enables CFG construction without a compiler (which is useful for unit tests).

@iritkatriel iritkatriel requested a review from markshannon as a code owner July 21, 2022 20:09
@iritkatriel iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 21, 2022
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 21, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 4bbebf8 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 21, 2022
@iritkatriel iritkatriel mentioned this pull request Jul 21, 2022
Closed
markshannon
markshannon reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

Python/compile.c Outdated Show resolved Hide resolved
@iritkatriel iritkatriel changed the title gh-93678: extract 'struct cfg' from the compiler so that the CFG can be manipulated directly gh-93678: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly Jul 26, 2022
@iritkatriel
Copy link
Member Author

@markshannon Any more comments on this?

markshannon
markshannon approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, I'd prefer we pass locations by value, but no need to do that for this PR.

@iritkatriel
Copy link
Member Author

FTR, I'd prefer we pass locations by value, but no need to do that for this PR.

Sure, might as well do it here.

@iritkatriel iritkatriel merged commit 75c0c1b into python:main Jul 26, 2022
@iritkatriel iritkatriel deleted the cfg_struct branch July 26, 2022 13:36
@iritkatriel iritkatriel mentioned this pull request Jul 27, 2022
Closed
@iritkatriel iritkatriel changed the title gh-93678: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly gh-95335: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iritkatriel @bedevere-bot @markshannon