-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-94808: Add coverage for bytesarray_setitem #95802
Conversation
5f24775
to
e717c5c
Compare
e717c5c
to
1c2a344
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Any reason you didn't mark this for backporting to 3.10?
No real reason not to -- for all these other coverage improvements linked to #94808, we've just been backporting to 3.11. |
Thanks @mdboom for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, @mdboom and @JelleZijlstra, I could not cleanly backport this to |
Sorry @mdboom and @JelleZijlstra, I had trouble checking out the |
Thanks! I think it's good to backport new tests to the bugfix branches so we can be more confident in any future bugfixes. But testing on 3.11 is definitely more important. Would you mind doing the manual backports? Feel free to skip 3.10 if you don't think it's worth it. |
When both are provided,
tp_ass_subscript
takes precedence overtp_ass_item
. Sincebytesarray
provides both, the existingtest_setitem
tests forbytesarray
were not testingbytesarray_setitem
, butbytesarray_ass_subscript
. This is mostly fine, since Python code has to jump through some hoops to even call it, but a third-party library usingPySequence_SetItem
could potentially run into this uncovered case.