-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-90928: Statically Initialize the Keywords Tuple in Clinic-Generated Code #95860
gh-90928: Statically Initialize the Keywords Tuple in Clinic-Generated Code #95860
Conversation
LGTM.
Yeah, its better to solve it for builtins now, extensions modules can be solved later on. Footnotes |
I'm glad you agree. 😄 Splitting it up this way made the most sense. |
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 3b308c4 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
CC. @colorfulappl, regarding your PR #32092. This PR touches some of the same parts of AC and getarg.c. |
We only statically initialize for core code and builtin modules. Extension modules still create the tuple at runtime. We'll solve that part of interpreter isolation separately.
This change includes generated code. The significant changes are in:
All other changes are generated code (clinic, global strings).