Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95957: Add instructions for Tcl/Tk and OpenSSL on RHEL/CentOS 7 #95964

Merged
merged 4 commits into from
Aug 16, 2022
Merged

gh-95957: Add instructions for Tcl/Tk and OpenSSL on RHEL/CentOS 7 #95964

merged 4 commits into from
Aug 16, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Aug 13, 2022 •
edited by bedevere-bot
Loading

@tiran tiran added the needs backport to 3.11 only security fixes label Aug 13, 2022
erlend-aasland
erlend-aasland reviewed Aug 14, 2022
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly look good. Generally TCL/TK => Tcl/Tk. Also, there are some lines with (assuming unintended) leading white-space, and some with trailing white-space.

Doc/whatsnew/3.11.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Documentation/2022-08-13-20-34-51.gh-issue-95957.W9ZZAx.rst Outdated Show resolved Hide resolved
tiran and others added 2 commits August 16, 2022 09:24
@tiran @erlend-aasland
Update Misc/NEWS.d/next/Documentation/2022-08-13-20-34-51.gh-issue-95…
1880cbf 
…957.W9ZZAx.rst

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@tiran
Address more code review comments
78a04d3
erlend-aasland
erlend-aasland approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more misspellings of Tcl/Tk, otherwise LGTM.

Misc/rhel7/README.md Outdated Show resolved Hide resolved
Misc/rhel7/README.md Outdated Show resolved Hide resolved
@tiran @erlend-aasland
Apply suggestions from code review
53584d8 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@tiran tiran changed the title gh-95957: Add instructions for TCL/TK and OpenSSL on RHEL/CentOS 7 gh-95957: Add instructions for Tcl/Tk and OpenSSL on RHEL/CentOS 7 Aug 16, 2022
@tiran tiran marked this pull request as ready for review August 16, 2022 11:08
@tiran tiran merged commit ab4d729 into python:main Aug 16, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@tiran tiran deleted the gh-95957-tcltk-pc branch August 16, 2022 11:44
@miss-islington
Copy link
Contributor

Sorry @tiran, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ab4d72954f3c3fe4bdf51dc6a9cf0ed38f210a68 3.11

@tiran tiran added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Aug 16, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-96022 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 16, 2022
@tiran @miss-islington
pythongh-95957: Add instructions for Tcl/Tk and OpenSSL on RHEL/CentO…
bf67caa 
…S 7 (pythonGH-95964)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit ab4d729)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 16, 2022
miss-islington added a commit that referenced this pull request Aug 18, 2022
@miss-islington @tiran
gh-95957: Add instructions for Tcl/Tk and OpenSSL on RHEL/CentOS 7 (G…
504da3c 
…H-95964)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit ab4d729)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

@tiran tiran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @miss-islington @bedevere-bot @erlend-aasland