gh-88355: Fix backslashes in AF_PIPE #96543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes.
|
All commit authors signed the Contributor License Agreement. |
CAM-Gerlach
added
needs backport to 3.10
CAM-Gerlach
approved these changes
Sep 26, 2022
|
Verified for correctness by referencing both https://github.com/python/cpython/blob/main/Lib/multiprocessing/connection.py#L108 And https://learn.microsoft.com/en-us/windows/win32/ipc/pipe-names |
|
Thanks @cousteaulecommandant for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-97854 is a backport of this pull request to the 3.11 branch. |
|
GH-97855 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 4, 2022
Fix backslashes in AF_PIPE (pythonGH-88355) The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes. (cherry picked from commit ff28d89) Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 4, 2022
Fix backslashes in AF_PIPE (pythonGH-88355) The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes. (cherry picked from commit ff28d89) Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com>
orsenthil
pushed a commit
that referenced
this pull request
Oct 4, 2022
gh-88355: Fix backslashes in AF_PIPE (GH-96543) Fix backslashes in AF_PIPE (GH-88355) The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes. (cherry picked from commit ff28d89) Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com> Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com>
orsenthil
pushed a commit
that referenced
this pull request
Oct 4, 2022
gh-88355: Fix backslashes in AF_PIPE (GH-96543) Fix backslashes in AF_PIPE (GH-88355) The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes. (cherry picked from commit ff28d89) Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com> Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com>
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
Fix backslashes in AF_PIPE (python#88355) The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes.
pablogsal
pushed a commit
that referenced
this pull request
Oct 22, 2022
gh-88355: Fix backslashes in AF_PIPE (GH-96543) Fix backslashes in AF_PIPE (GH-88355) The correct syntax for AF_PIPE addresses is `\\.\pipe\blahblah`, not `\.\pipe{blahblah}`, but the syntax markup messed up the backslashes. (cherry picked from commit ff28d89) Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com> Co-authored-by: cousteau <cousteaulecommandant@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct syntax for AF_PIPE addresses is
\\.\pipe\blahblah, not\.\pipe{blahblah}, but the syntax markup messed up the backslashes.