Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-96636: Remove all uses of NOTRACE_DISPATCH #96643

Merged
merged 10 commits into from
Sep 8, 2022
Merged

GH-96636: Remove all uses of NOTRACE_DISPATCH #96643

merged 10 commits into from
Sep 8, 2022

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Sep 7, 2022 •
edited by bedevere-bot
Loading

brandtbucher
brandtbucher approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR!

Lib/test/test_dynamic.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Core and Builtins/2022-09-07-12-02-11.gh-issue-96636.YvN-K6.rst Outdated Show resolved Hide resolved
Lib/test/test_dynamic.py Outdated Show resolved Hide resolved
@mdboom
Copy link
Contributor

mdboom commented Sep 7, 2022

Naive question: Do we expect this to have a performance impact, and should we measure it?

@brandtbucher
Copy link
Member

Mark and I both benchmarked similar changes independently this week. I saw a 0% slowdown, he saw a 1% slowdown. So the perf impact is likely <1%.

markshannon and others added 3 commits September 7, 2022 16:38
@markshannon @brandtbucher
Update Lib/test/test_dynamic.py
5872b7a 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@markshannon @brandtbucher
Update Misc/NEWS.d/next/Core and Builtins/2022-09-07-12-02-11.gh-issu…
7ff1782 
…e-96636.YvN-K6.rst

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@markshannon @brandtbucher
Update Lib/test/test_dynamic.py
ff834d6 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@Fidget-Spinner Fidget-Spinner changed the title GH-96636: Remove unsafe uses of NOTRACE_DISPATCH GH-96636: Remove all uses of NOTRACE_DISPATCH Sep 7, 2022
Fidget-Spinner
Fidget-Spinner approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The fix looks fine. Just one question about the tests.

Lib/test/test_dynamic.py Show resolved Hide resolved
gvanrossum
gvanrossum reviewed Sep 7, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits.

Lib/test/test_dynamic.py Show resolved Hide resolved
Lib/test/test_dynamic.py Outdated Show resolved Hide resolved
Lib/test/test_dynamic.py Show resolved Hide resolved
Python/ceval.c Show resolved Hide resolved
@markshannon markshannon added the needs backport to 3.11 only security fixes label Sep 8, 2022
@markshannon markshannon merged commit aa3b4cf into python:main Sep 8, 2022
@miss-islington
Copy link
Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @markshannon, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker aa3b4cf779b3dddb84e094879b91703354910d8c 3.11

@markshannon markshannon deleted the remove-unsafe-notrace-dispatch branch September 8, 2022 16:22
markshannon added a commit to faster-cpython/cpython that referenced this pull request Sep 8, 2022
@markshannon
pythonGH-96636: Remove all uses of NOTRACE_DISPATCH (pythonGH-96643)
c3e987b 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit aa3b4cf)
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 8, 2022
@bedevere-bot
Copy link

GH-96688 is a backport of this pull request to the 3.11 branch.

gvanrossum pushed a commit that referenced this pull request Sep 9, 2022
@markshannon
[3.11] GH-96636: Remove all uses of NOTRACE_DISPATCH (GH-96643) (#96688)
5586da6 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit aa3b4cf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweeneyde sweeneyde sweeneyde left review comments

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

@markshannon markshannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@markshannon @mdboom @brandtbucher @miss-islington @bedevere-bot @gvanrossum @Fidget-Spinner @sweeneyde