Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-96821: Add config option --with-strict-overflow #96823

Merged
merged 38 commits into from
Mar 4, 2023
Merged

gh-96821: Add config option --with-strict-overflow #96823

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
8863e74
gh-96821: Mark modules that need -fno-strict-overflow
matthiasgoergens Sep 14, 2022
0598ea9
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 14, 2022
50cbb61
Drop fwrapv
matthiasgoergens Sep 14, 2022
f4f3b83
Merge branch 'main' into strict_overflow
matthiasgoergens Sep 16, 2022
8015da0
Merge branch 'main' into strict_overflow
matthiasgoergens Sep 16, 2022
d2a2c82
Foo
matthiasgoergens Sep 17, 2022
25b15bf
fix
matthiasgoergens Sep 17, 2022
86d01d6
Even I can't remember the f
matthiasgoergens Sep 17, 2022
ca2d023
Merge remote-tracking branch 'matthias/strict_overflow' into strict_o…
matthiasgoergens Sep 17, 2022
43baf35
Merge remote-tracking branch 'origin/main' into strict_overflow
matthiasgoergens Sep 17, 2022
2b6ade9
Fix typo
matthiasgoergens Sep 18, 2022
9d402a8
Merge branch 'main' into strict_overflow
matthiasgoergens Sep 18, 2022
e5cff7b
News
matthiasgoergens Sep 18, 2022
2118727
Merge remote-tracking branch 'matthias/strict_overflow' into strict_o…
matthiasgoergens Sep 18, 2022
a2bb1e9
Update Misc/NEWS.d/next/Build/2022-09-14-10-38-15.gh-issue-96821.Zk2a…
matthiasgoergens Sep 19, 2022
89ba064
Merge branch 'main' into strict_overflow
matthiasgoergens Sep 19, 2022
8d50ae4
Merge branch 'main' into strict_overflow
matthiasgoergens Sep 20, 2022
71ca2a5
Merge remote-tracking branch 'origin/main' into strict_overflow
matthiasgoergens Sep 21, 2022
8538fe6
Fix comments and quoting
matthiasgoergens Sep 21, 2022
26956f3
Fix News
matthiasgoergens Sep 21, 2022
88a2c76
_testcapi is strict-overflow clean now
matthiasgoergens Sep 21, 2022
4f95dba
Merge branch 'main' into strict_overflow
matthiasgoergens Sep 26, 2022
506d77e
Merge branch 'main' into strict_overflow
matthiasgoergens Sep 27, 2022
d45d6ae
Update configure.ac
matthiasgoergens Oct 3, 2022
f6d3113
Update configure.ac
matthiasgoergens Oct 3, 2022
d6423c7
Update configure.ac
matthiasgoergens Oct 3, 2022
0f2f931
Merge branch 'main' into strict_overflow
matthiasgoergens Oct 3, 2022
3b4046f
_struct is already strict-overflow safe
matthiasgoergens Oct 3, 2022
3995eb6
Merge remote-tracking branch 'origin/main' into strict_overflow
matthiasgoergens Oct 11, 2022
2714d61
We fixed audioop, so remove it from list of exceptions
matthiasgoergens Oct 11, 2022
6236fb9
Document our --with-strict-overflow
matthiasgoergens Oct 11, 2022
ca6e6ba
Update Doc/using/configure.rst
matthiasgoergens Oct 12, 2022
fa14763
Update Misc/NEWS.d/next/Build/2022-09-14-10-38-15.gh-issue-96821.Zk2a…
matthiasgoergens Oct 12, 2022
6b09fa7
Merge branch 'main' into strict_overflow
matthiasgoergens Oct 12, 2022
9f34477
improve help message
hauntsaninja Jan 20, 2023
7116f84
Merge branch 'main' into strict_overflow
erlend-aasland Jan 20, 2023
e526f6e
fix cache, add warning
hauntsaninja Jan 23, 2023
db665ab
use warn, not error
hauntsaninja Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Build/2022-09-14-10-38-15.gh-issue-96821.Zk2a9c.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Explicitly mark C modules that need defined signed integer overflow. (So that in future we can turn off the blanket `-fwrapv`, and enjoy more C compiler optimizations.)
matthiasgoergens marked this conversation as resolved.
Show resolved Hide resolved
8 changes: 4 additions & 4 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7222,7 +7222,7 @@ PY_STDLIB_MOD_SIMPLE([_posixsubprocess])
PY_STDLIB_MOD_SIMPLE([_queue])
PY_STDLIB_MOD_SIMPLE([_random])
PY_STDLIB_MOD_SIMPLE([select])
PY_STDLIB_MOD_SIMPLE([_struct])
PY_STDLIB_MOD_SIMPLE([_struct], [-fno-strict-overflow])
PY_STDLIB_MOD_SIMPLE([_typing])
PY_STDLIB_MOD_SIMPLE([_xxsubinterpreters])
PY_STDLIB_MOD_SIMPLE([_zoneinfo])
Expand All @@ -7236,7 +7236,7 @@ PY_STDLIB_MOD([_posixshmem],
[$POSIXSHMEM_CFLAGS], [$POSIXSHMEM_LIBS])

dnl needs libm
PY_STDLIB_MOD_SIMPLE([audioop], [], [$LIBM])
PY_STDLIB_MOD_SIMPLE([audioop], [-fno-strict-overflow], [$LIBM])
PY_STDLIB_MOD_SIMPLE([_statistics], [], [$LIBM])
PY_STDLIB_MOD_SIMPLE([cmath], [], [$LIBM])
PY_STDLIB_MOD_SIMPLE([math], [], [$LIBM])
Expand Down Expand Up @@ -7297,7 +7297,7 @@ PY_STDLIB_MOD([_crypt],
[$LIBCRYPT_CFLAGS], [$LIBCRYPT_LIBS])
PY_STDLIB_MOD([_ctypes],
[], [test "$have_libffi" = yes],
[$LIBFFI_CFLAGS], [$LIBFFI_LIBS])
[-fno-strict-overflow $LIBFFI_CFLAGS], [$LIBFFI_LIBS])
PY_STDLIB_MOD([_curses],
[], [test "$have_curses" != "no"],
[$CURSES_CFLAGS], [$CURSES_LIBS]
Expand Down Expand Up @@ -7347,7 +7347,7 @@ PY_STDLIB_MOD([_hashlib], [], [test "$ac_cv_working_openssl_hashlib" = yes],
[$OPENSSL_INCLUDES], [$OPENSSL_LDFLAGS $OPENSSL_LDFLAGS_RPATH $LIBCRYPTO_LIBS])

dnl test modules
PY_STDLIB_MOD([_testcapi], [test "$TEST_MODULES" = yes])
PY_STDLIB_MOD([_testcapi], [test "$TEST_MODULES" = yes], [], [-fno-strict-overflow])
PY_STDLIB_MOD([_testinternalcapi], [test "$TEST_MODULES" = yes])
PY_STDLIB_MOD([_testbuffer], [test "$TEST_MODULES" = yes])
PY_STDLIB_MOD([_testimportmultiple], [test "$TEST_MODULES" = yes], [test "$ac_cv_func_dlopen" = yes])
Expand Down