-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-96861: Check for unset sys.executable during venv creation. (GH-96887) #96887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vsajip
commented
Sep 17, 2022
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: venv.create() fails when sys._base_executable is empty #96861
vsajip
changed the title
gh-96861: Check for unset sys.executable during venv creation.
gh-96861: Check for unset sys.executable during venv creation. (GH-96887)
Sep 17, 2022
vsajip
added
needs backport to 3.10
only security fixes
needs backport to 3.11
only security fixes
and removed
type-feature
A feature request or enhancement
labels
Sep 18, 2022
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-96918 is a backport of this pull request to the 3.10 branch. |
GH-96919 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 18, 2022
…ythonGH-96887) (cherry picked from commit 2cd70ff) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 18, 2022
…ythonGH-96887) (cherry picked from commit 2cd70ff) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
vsajip
added a commit
that referenced
this pull request
Sep 18, 2022
vsajip
pushed a commit
that referenced
this pull request
Sep 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.