Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-96959: Update HTTP links which are redirected to HTTPS #96961

Merged
merged 4 commits into from
Sep 24, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 20, 2022

Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka requested a review from a team as a code owner September 20, 2022 15:26
LICENSE Outdated
@@ -2,7 +2,7 @@ A. HISTORY OF THE SOFTWARE
==========================

Python was created in the early 1990s by Guido van Rossum at Stichting
Mathematisch Centrum (CWI, see http://www.cwi.nl) in the Netherlands
Mathematisch Centrum (CWI, see https://www.cwi.nl) in the Netherlands
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already https in Doc/license.rst.

LICENSE Outdated
@@ -19,7 +19,7 @@ https://www.python.org/psf/) was formed, a non-profit organization
created specifically to own Python-related Intellectual Property.
Zope Corporation was a sponsoring member of the PSF.

All Python releases are Open Source (see http://www.opensource.org for
All Python releases are Open Source (see https://opensource.org for
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already https in Doc/license.rst.

@@ -181,7 +181,7 @@ How do I create documentation from doc strings?
The :mod:`pydoc` module can create HTML from the doc strings in your Python
source code. An alternative for creating API documentation purely from
docstrings is `epydoc <http://epydoc.sourceforge.net/>`_. `Sphinx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only has http -- https://epydoc.sourceforge.net/ fails.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the https link works now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm. Do you mind to create a pull request?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it has already been fixed in a different PR dd53b79

My mistake!

@serhiy-storchaka serhiy-storchaka merged commit db39050 into python:main Sep 24, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the doc-links-http branch September 24, 2022 11:38
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 24, 2022
@bedevere-bot
Copy link

GH-97521 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 24, 2022
…onGH-96961)

(cherry picked from commit db39050)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-97522 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 24, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 24, 2022
…onGH-96961)

(cherry picked from commit db39050)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Sep 25, 2022
(cherry picked from commit db39050)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Sep 25, 2022
(cherry picked from commit db39050)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants