Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-97825: fix AttributeError when calling subprocess.check_output(input=None) with encoding or errors args #97826

Merged
merged 3 commits into from
Oct 5, 2022
Merged

gh-97825: fix AttributeError when calling subprocess.check_output(input=None) with encoding or errors args #97826

merged 3 commits into from
Oct 5, 2022

Conversation

akulakov
Copy link
Contributor

@akulakov akulakov commented Oct 4, 2022 •
edited by bedevere-bot
Loading

@akulakov akulakov requested a review from gpshead as a code owner October 4, 2022 07:44
JelleZijlstra
JelleZijlstra approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right and mirrors the logic at

cpython/Lib/subprocess.py

Line 904 in 4f380db

self.text_mode = encoding or errors or text or universal_newlines
for deciding whether to use text mode.

@gpshead gpshead added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes type-bug An unexpected behavior, bug, or error labels Oct 5, 2022
@gpshead gpshead merged commit db64fb9 into python:main Oct 5, 2022
@miss-islington
Copy link
Contributor

Thanks @akulakov for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 5, 2022
@bedevere-bot
Copy link

GH-97880 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2022
@akulakov @miss-islington
pythongh-97825: fix AttributeError when calling subprocess.check_outp…
537a90f 
…ut(input=None) with encoding or errors args (pythonGH-97826)

* fix AttributeError, add unit test
(cherry picked from commit db64fb9)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@bedevere-bot
Copy link

GH-97881 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2022
@akulakov @miss-islington
pythongh-97825: fix AttributeError when calling subprocess.check_outp…
b771e84 
…ut(input=None) with encoding or errors args (pythonGH-97826)

* fix AttributeError, add unit test
(cherry picked from commit db64fb9)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
miss-islington added a commit that referenced this pull request Oct 5, 2022
@miss-islington @akulakov
gh-97825: fix AttributeError when calling subprocess.check_output(inp…
9133aab 
…ut=None) with encoding or errors args (GH-97826)

* fix AttributeError, add unit test
(cherry picked from commit db64fb9)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
miss-islington added a commit that referenced this pull request Oct 5, 2022
@miss-islington @akulakov
gh-97825: fix AttributeError when calling subprocess.check_output(inp…
ece5f7e 
…ut=None) with encoding or errors args (GH-97826)

* fix AttributeError, add unit test
(cherry picked from commit db64fb9)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
carljm added a commit to carljm/cpython that referenced this pull request Oct 6, 2022
@carljm
Merge branch 'main' into dictwatch
4bb5d9d 
* main: (66 commits)
  pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879)
  docs(typing): add "see PEP 675" to LiteralString (python#97926)
  pythongh-97850: Remove all known instances of module_repr() (python#97876)
  I changed my surname early this year (python#96671)
  pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768)
  pythongh-91539: improve performance of get_proxies_environment  (python#91566)
  build(deps): bump actions/stale from 5 to 6 (python#97701)
  pythonGH-95172 Make the same version `versionadded` oneline (python#95172)
  pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073)
  pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774)
  pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (python#97896)
  pythongh-95196: Disable incorrect pickling of the C implemented classmethod descriptors (pythonGH-96383)
  pythongh-97758: Fix a crash in getpath_joinpath() called without arguments (pythonGH-97759)
  pythongh-74696: Pass root_dir to custom archivers which support it (pythonGH-94251)
  pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (python#97662)
  pythongh-87092: bring compiler code closer to a preprocessing-opt-assembler organisation (pythonGH-97644)
  pythonGH-96704: Add {Task,Handle}.get_context(), use it in call_exception_handler() (python#96756)
  pythongh-93738: Documentation C syntax (:c:type:`PyTypeObject*` -> :c:expr:`PyTypeObject*`) (python#97778)
  pythongh-97825: fix AttributeError when calling subprocess.check_output(input=None) with encoding or errors args (python#97826)
  Add re.VERBOSE flag documentation example (python#97678)
  ...
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@akulakov @mpage
pythongh-97825: fix AttributeError when calling subprocess.check_outp…
2efca9c 
…ut(input=None) with encoding or errors args (python#97826)

* fix AttributeError, add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akulakov @miss-islington @bedevere-bot @gpshead @JelleZijlstra