Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34971: add support for TLS sessions from asyncio #9840

Closed
wants to merge 1 commit into from
Closed

bpo-34971: add support for TLS sessions from asyncio #9840

wants to merge 1 commit into from

Conversation

RemiCardona
Copy link

@RemiCardona RemiCardona commented Oct 13, 2018 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@matrixise matrixise mentioned this pull request Oct 15, 2018
Closed
tiran
tiran reviewed Oct 22, 2018
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing session code is TLS 1.2 only. For TLS 1.3, I need to come up with a complete redesign first. Even for TLS 1.2, the existing session code is buggy, because TLS connections can't be terminated properly. IMHO it doesn't make sense to add a partly broken feature.

@1st1
Copy link
Member

1st1 commented Feb 14, 2019

(waiting for @tiran's approval of this new feature before we begin to consider it)

@RemiCardona
Copy link
Author

@tiran any news on TLS redesign? Where is this effort taking place? How can I help or get involved in any way? Thanks

@tiran
Copy link
Member

tiran commented May 1, 2019

@RemiCardona I'm at PyCon and will work with some people on a new design.

@cooperlees
Copy link
Contributor

How did the redesign go? I'd love to get this in so we can make aiohttp support HTTPS proxies for cpython 3.8 :)

@cooperlees cooperlees mentioned this pull request Jun 6, 2019
Closed
@RemiCardona RemiCardona mannequin mentioned this pull request Apr 10, 2022
Closed
@gvanrossum
Copy link
Member

This PR is hopelessly out of date (it seems from the discussion above as well as the merge conflicts) but fortunately #79156 and #91453 add the desired functionality -- there's now a start_tls() method on event loops and another on streams.

@gvanrossum gvanrossum closed this Oct 4, 2022
@gvanrossum
Copy link
Member

Apparently I was premature closing this. Reopening (but this isn't my specialty, so I'm not going to help you get this merged -- sorry).

@gvanrossum gvanrossum reopened this Oct 4, 2022
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@cpython-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran left review comments

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
awaiting review DO-NOT-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@RemiCardona @the-knights-who-say-ni @1st1 @tiran @cooperlees @gvanrossum @bedevere-bot @ezio-melotti @kumaraditya303