Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-1420: Add a note about long paths support to Windows buildbot setup #1421

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

itamaro
Copy link
Contributor

@itamaro itamaro commented Sep 27, 2024

@zware
Copy link
Member

zware commented Sep 27, 2024

I'm torn on this one :). It's good information to add, but ideally our tests should handle the 'disabled' case, since it's the default.

@itamaro
Copy link
Contributor Author

itamaro commented Sep 27, 2024

It's good information to add, but ideally our tests should handle the 'disabled' case, since it's the default.

why not both? :)

if the test suite handles the disabled case (likely by skipping some tests when long paths are disabled), then we probably want to nudge buildbot worker maintainers to enable long paths to get more comprehensive coverage.

@zware
Copy link
Member

zware commented Sep 28, 2024

Fair enough.

@zware zware merged commit 87d74ce into python:main Sep 28, 2024
5 checks passed
@ezio-melotti ezio-melotti linked an issue Oct 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a note about Windows long paths support
2 participants