Fix good commit example to use imperative title #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix example to use imperative title - Explicitly mention the preference for imperative over descriptive titles - Link to the article from Chris Beams
aeros
reviewed
May 22, 2020
There was a problem hiding this comment.
Thanks for the PR @DahlitzFlorian. It mostly LGTM; I just have a very minor suggestion.
Since this issue is very well defined and straightforward, I'm good w/ merging it after the suggested changes are made.
|
Thanks for the fast feedback @aeros! I applied your suggestion. |
terryjreedy
requested changes
May 22, 2020
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
LGTM. Kyle, leaving this for you if you get to it. |
aeros
reviewed
May 25, 2020
Co-authored-by: Kyle Stanley <aeros167@gmail.com>
aeros
approved these changes
May 25, 2020
There was a problem hiding this comment.
With the latest changes, LGTM. Thanks for working on this @DahlitzFlorian.
AA-Turner
pushed a commit
to AA-Turner/devguide
that referenced
this pull request
Jun 17, 2022
* Explicitly mention the preference for imperative over descriptive titles * Link to the article from Chris Beams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #577
@gvanrossum I added the link to the article as suggested by you. The Git Bootcamp is mentioning the article, too, but I agree with you that it is better to explicitly mention it at this point, too.