Give precedence to native traversable readers. #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
force-pushed
the
feature/better-native-reader-support
branch
from
e857e8a
to
bf02178
Compare
Ensure that standard library readers are replaced while third-party readers are passed along. Closes #295.
jaraco
force-pushed
the
feature/better-native-reader-support
branch
from
bf02178
to
527173b
Compare
…raversableResourcesLoader and ensure that the known standard readers are replaced by readers from importlib_resources.
|
The diffcov tests are failing, but that's mainly due to the fact that pytest is importing the module before coverage starts, but also because coverage isn't checked across Python versions. |
|
I'm going to proceed with merging these changes and getting them released. If there are emergent issues, we can iterate or roll back. |
|
This change seems to have reintroduced #257. The recreation scenario works with 6.1.3 but fails with 6.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that standard library readers are replaced while third-party readers are passed along. Closes #295.