Suggest solutions for a typo in a key of a TypedDict (#8483)

python · Mar 6, 2020 · 1180a9d · 1180a9d
1 parent d2e984a
commit 1180a9d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/mypy/messages.py b/mypy/messages.py
@@ -1146,6 +1146,9 @@ def typeddict_key_not_found(
                 item_name, format_item_name_list(typ.items.keys())), context)
         else:
             self.fail("TypedDict {} has no key '{}'".format(format_type(typ), item_name), context)
+            matches = best_matches(item_name, typ.items.keys())
+            if matches:
+                self.note("Did you mean {}?".format(pretty_seq(matches[:3], "or")), context)
 
     def typeddict_context_ambiguous(
             self,

diff --git a/test-data/unit/check-typeddict.test b/test-data/unit/check-typeddict.test
@@ -666,7 +666,8 @@ reveal_type(c[u'value'])  # N: Revealed type is 'builtins.int'
 from mypy_extensions import TypedDict
 TaggedPoint = TypedDict('TaggedPoint', {'type': str, 'x': int, 'y': int})
 p: TaggedPoint
-p['z']  # E: TypedDict "TaggedPoint" has no key 'z'
+p['typ']  # E: TypedDict "TaggedPoint" has no key 'typ' \
+          # N: Did you mean "type"?
 [builtins fixtures/dict.pyi]
 
 [case testTypedDictWithUnicodeName]