Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypyc runtime tests with py39-macos is unstable #16420

Closed
WeilerMarcel opened this issue Nov 8, 2023 · 2 comments · Fixed by #16520
Closed

mypyc runtime tests with py39-macos is unstable #16420

WeilerMarcel opened this issue Nov 8, 2023 · 2 comments · Fixed by #16520
Labels
bug mypy got something wrong

Comments

@WeilerMarcel
Copy link
Contributor

Bug Report

The following tests in mypyc runtime tests with py39-macos spuriously failed during PR #14934 , even though I did not touch any code related to them:

  • testIncrementalCompilation1_separate
  • testIncrementalCompilation4_separate

I added two empty dummy commits to get the pipeline to succeed. The following three commits have no code changes, but for the first two some of the tests fail:

To Reproduce

Trigger a CI pipeline run without code changes.

Expected Behavior

The test runs are consistent.

Actual Behavior

Tests spuriously fail. See links to the log files above.

Your Environment

This happened in the CI runs of !PR #14934.

@JukkaL
Copy link
Collaborator

JukkaL commented Nov 8, 2023

Yeah, the macOS mypyc runtime tests have been flaky for some time now. We have some hypotheses about what might be going on, but as far as I know this still bit of a mystery.

@hauntsaninja
Copy link
Collaborator

I wasn't aware we had hypotheses! The only thing I confirmed was that it doesn't seem to be related to any code change in mypy, something changed out from underneath us

ilevkivskyi added a commit that referenced this issue Nov 19, 2023
Fixes #16420

Although this is not 100% clear yet, but after 20 runs on a Mac I have
it no longer fails (without this patch it failed 20% of times). Btw,
contrary to the comment, _my_ Linux Mint (which is an Ubuntu derivative)
works perfectly (i.e. test passed 20 times even after I removed the
`sleep()`). So it is not really Mac vs Linux issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug mypy got something wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants