Add support for assert_type #12584
Merged
Add support for assert_type #12584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See python/cpython#30843. The implementation mostly follows that of cast(). It relies on `mypy.sametypes.is_same_type()`.
This comment has been minimized.
This comment has been minimized.
|
For comparison, the implementation in pyright is in microsoft/pyright@4edb1b4 (6 files, 96 lines) and the one in pyanalyze is in quora/pyanalyze@b11f15a (4 files, 80 lines). |
This comment has been minimized.
This comment has been minimized.
msullivan
approved these changes
Apr 14, 2022
hauntsaninja
approved these changes
Apr 15, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JukkaL
pushed a commit
that referenced
this pull request
Apr 20, 2022
See python/cpython#30843. The implementation mostly follows that of cast(). It relies on `mypy.sametypes.is_same_type()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See python/cpython#30843.
The implementation mostly follows that of cast(). It relies on
mypy.sametypes.is_same_type().