Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class objects falling back to metaclass for callback protocol #14121

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

ilevkivskyi
Copy link
Member

Fixes #10482

This is not very principled, but should work except people will want to explicitly check some metaclass __call__.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is a reasonable fix, since we don't properly support metaclass __call__ methods anyway. Callable protocols seem like a much more common use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Treatment of Class Constructor by Protocol
2 participants