Correctly handle Enum name on Python 3.11 #14133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
AlexWaygood
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Looks good, and it's great to have this fixed. This PR also fixes python/typeshed#7564.
There's still the outstanding issue that mypy won't spot that this will raise an AttributeError at runtime on 3.11+:
import enum
class E(enum.Enum):
X = 1
@enum.property
def foo(self) -> int: return 42
assert E.X.foo == 42 # this is fine
E.foo # AttributeError raised here at runtimeBut this is a much lower-priority problem, and can be filed as a follow-up issue.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
1 task
JukkaL
pushed a commit
that referenced
this pull request
Nov 21, 2024
This enables typeshed to define types.DynamicClassAttribute as a different class from builtins.property without breakage. Would enable python/typeshed#12762 see also #14133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12483
Fixes python/typeshed#7564
Ref #12841
The fix is straightforward. I can't use a unit test for this because there are some builtins fixtures that don't have tuple, so I can't do version check.