Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance for errors on class with many attributes #14379

Merged
merged 4 commits into from
Jan 3, 2023
Merged

Improve performance for errors on class with many attributes #14379

merged 4 commits into from
Jan 3, 2023

Commits on Jan 3, 2023

  1. Improve performance for errors on class with many attributes 

    When checking manticore with `--check-untyped-defs`, this is a 4x total
speedup from master, from ~320s to ~80s.

I looked into this because of python/typeshed#9443 (comment)
    @hauntsaninja
    hauntsaninja committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    b023304 View commit details
    Browse the repository at this point in the history

  2. better precision

    @hauntsaninja
    hauntsaninja committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    df87d87 View commit details
    Browse the repository at this point in the history

  3. sort alphabetically, make ratio strictly greater

    @hauntsaninja
    hauntsaninja committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    9419117 View commit details
    Browse the repository at this point in the history

  4. add types

    @hauntsaninja
    hauntsaninja committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    20bdfd7 View commit details
    Browse the repository at this point in the history