In error messages, quote just the module's name #14567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ikonst
force-pushed
the
2023-01-31-module-quote
branch
from
a35f4b6 to
3c995b3
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: Tanjun (https://github.com/FasterSpeeding/Tanjun)
- version: 1.0.0+dev.1a781e7b46fa362718259187ca1f7cdfd9fad136
+ version: 1.0.0+dev.a5d3de22febda4d3e24093558cfc4ea5c51a001a
streamlit (https://github.com/streamlit/streamlit)
- lib/tests/streamlit/watcher/local_sources_watcher_test.py:232:13: error: "Module streamlit.watcher.local_sources_watcher" does not explicitly export attribute "get_default_path_watcher_class" [attr-defined]
+ lib/tests/streamlit/watcher/local_sources_watcher_test.py:232:13: error: Module "streamlit.watcher.local_sources_watcher" does not explicitly export attribute "get_default_path_watcher_class" [attr-defined]
- lib/tests/streamlit/watcher/local_sources_watcher_test.py:238:13: error: "Module streamlit.watcher.local_sources_watcher" does not explicitly export attribute "get_default_path_watcher_class" [attr-defined]
+ lib/tests/streamlit/watcher/local_sources_watcher_test.py:238:13: error: Module "streamlit.watcher.local_sources_watcher" does not explicitly export attribute "get_default_path_watcher_class" [attr-defined]
- lib/tests/streamlit/watcher/local_sources_watcher_test.py:244:13: error: "Module streamlit.watcher.local_sources_watcher" does not explicitly export attribute "get_default_path_watcher_class" [attr-defined]
+ lib/tests/streamlit/watcher/local_sources_watcher_test.py:244:13: error: Module "streamlit.watcher.local_sources_watcher" does not explicitly export attribute "get_default_path_watcher_class" [attr-defined]
- lib/tests/streamlit/watcher/local_sources_watcher_test.py:249:30: error: "Module streamlit.watcher.local_sources_watcher" does not explicitly export attribute "get_default_path_watcher_class" [attr-defined]
+ lib/tests/streamlit/watcher/local_sources_watcher_test.py:249:30: error: Module "streamlit.watcher.local_sources_watcher" does not explicitly export attribute "get_default_path_watcher_class" [attr-defined]
- lib/tests/streamlit/watcher/local_sources_watcher_test.py:253:17: error: "Module streamlit.watcher.local_sources_watcher" does not explicitly export attribute "get_default_path_watcher_class" [attr-defined]
+ lib/tests/streamlit/watcher/local_sources_watcher_test.py:253:17: error: Module "streamlit.watcher.local_sources_watcher" does not explicitly export attribute "get_default_path_watcher_class" [attr-defined]
- lib/tests/streamlit/web/server/server_test.py:337:42: error: "Module streamlit.config" does not explicitly export attribute "ConfigOption" [attr-defined]
+ lib/tests/streamlit/web/server/server_test.py:337:42: error: Module "streamlit.config" does not explicitly export attribute "ConfigOption" [attr-defined]
urllib3 (https://github.com/urllib3/urllib3)
- docs/conf.py:57: error: "Module urllib3" does not explicitly export attribute "__version__" [attr-defined]
+ docs/conf.py:57: error: Module "urllib3" does not explicitly export attribute "__version__" [attr-defined]
|
JelleZijlstra
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it consistent with other error messages, e.g.
mypy/mypy/semanal.py
Lines 2572 to 2574 in 1a781e7