Fix over eager types-google-cloud-ndb suggestion #15347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ikonst
reviewed
Jun 2, 2023
| @@ -116,7 +116,7 @@ def stub_package_name(prefix: str) -> str: | |||
| "flask_sqlalchemy": "types-Flask-SQLAlchemy", | |||
| "fpdf": "types-fpdf2", | |||
| "gdb": "types-gdb", | |||
| "google.cloud": "types-google-cloud-ndb", | |||
| "google.cloud.ndb": "types-google-cloud-ndb", | |||
There was a problem hiding this comment.
Don't forget to update the comment above re: a.b.
for more information, see https://pre-commit.ci
|
Diff from mypy_primer, showing the effect of this PR on open source code: scrapy (https://github.com/scrapy/scrapy)
+ scrapy/utils/ssl.py:3: error: Library stubs not installed for "OpenSSL._util" [import-untyped]
+ scrapy/utils/ssl.py:3: note: Hint: "python3 -m pip install types-pyOpenSSL"
+ scrapy/utils/ssl.py:3: note: (or run "mypy --install-types" to install all missing stub packages)
+ scrapy/utils/ssl.py:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
ikonst
approved these changes
Aug 10, 2023
| # Don't honor a global (not per-module) ignore_missing_imports | ||
| # setting for modules that used to have bundled stubs, as | ||
| # otherwise updating mypy can silently result in new false | ||
| # negatives. (Unless there are stubs but they are incomplete.) | ||
| global_ignore_missing_imports = manager.options.ignore_missing_imports | ||
| if ( | ||
| (is_legacy_bundled_package(top_level) or is_legacy_bundled_package(second_level)) | ||
| any( | ||
| ".".join(id_components[:i]) in legacy_bundled_packages |
There was a problem hiding this comment.
I considered if the iteration could be wrapped in a func but can't think of a name that's clearer than the literal code
hauntsaninja
added a commit
to falsedrow/mypy
that referenced
this pull request
Oct 25, 2024
hauntsaninja
added a commit
to falsedrow/mypy
that referenced
this pull request
Oct 25, 2024
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15343