Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ast warnings for Python3.12 #15558

Merged
merged 9 commits into from
Jul 3, 2023
Merged

Fix ast warnings for Python3.12 #15558

merged 9 commits into from
Jul 3, 2023

Conversation

sobolevn
Copy link
Member

Warnings before: #15330 (comment)
Warnings after:

(.venv312) ~/Desktop/mypy  master ✗                                                       
» python -m mypy ex.py
Success: no issues found in 1 source file

Zero :)

@github-actions

This comment has been minimized.

@JelleZijlstra
Copy link
Member

Seems like there's more to be done. We're getting a None here:

  File "/home/runner/work/mypy/mypy/mypy/fastparse.py", line 1960, in _extract_argument_name
    return n.s.strip()

The mypy-primer hit also likely indicates a bug. It's something with type comments.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@sobolevn sobolevn requested a review from JelleZijlstra July 1, 2023 06:18
@JelleZijlstra
Copy link
Member

We dropped support for 3.7 by now, so this can probably be simplified; at least there's a big merge conflict now.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@sobolevn sobolevn merged commit a759c49 into master Jul 3, 2023
@sobolevn sobolevn deleted the issue-15330 branch July 3, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants