Fix type narrowing in lambda expressions #16407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: openlibrary (https://github.com/internetarchive/openlibrary)
+ openlibrary/plugins/upstream/utils.py:813: error: Unused "type: ignore" comment [unused-ignore]
jax (https://github.com/google/jax)
+ jax/_src/interpreters/pxla.py:2117: error: Unused "type: ignore" comment [unused-ignore]
operator (https://github.com/canonical/operator)
+ ops/testing.py:1741: error: Unused "type: ignore" comment [unused-ignore]
spark (https://github.com/apache/spark)
+ python/pyspark/sql/pandas/types.py:775: error: Unused "type: ignore" comment [unused-ignore]
+ python/pyspark/sql/pandas/types.py:1032: error: Unused "type: ignore" comment [unused-ignore]
discord.py (https://github.com/Rapptz/discord.py)
- discord/player.py:578: error: "None" not callable [misc]
- discord/player.py:586: error: "None" not callable [misc]
- discord/player.py:586: error: Argument 2 to "_probe_codec_fallback" of "FFmpegOpusAudio" has incompatible type "str | None"; expected "str" [arg-type]
- discord/scheduled_event.py:654: error: Item "None" of "Snowflake | None" has no attribute "id" [union-attr]
- discord/state.py:1101: error: Argument 1 to "store_emoji" of "ConnectionState" has incompatible type "Guild | None"; expected "Guild" [arg-type]
- discord/state.py:1114: error: Argument 1 to "store_sticker" of "ConnectionState" has incompatible type "Guild | None"; expected "Guild" [arg-type]
- discord/guild.py:3926: error: Item "datetime" of "Snowflake | datetime" has no attribute "id" [union-attr]
- discord/client.py:2167: error: Item "datetime" of "Snowflake | datetime | None" has no attribute "id" [union-attr]
- discord/client.py:2167: error: Item "None" of "Snowflake | datetime | None" has no attribute "id" [union-attr]
- discord/abc.py:1787: error: Item "datetime" of "Snowflake | datetime | None" has no attribute "id" [union-attr]
- discord/abc.py:1787: error: Item "None" of "Snowflake | datetime | None" has no attribute "id" [union-attr]
- discord/abc.py:1789: error: Item "datetime" of "Snowflake | datetime | None" has no attribute "id" [union-attr]
- discord/abc.py:1789: error: Item "None" of "Snowflake | datetime | None" has no attribute "id" [union-attr]
- discord/abc.py:1793: error: Item "datetime" of "Snowflake | datetime | None" has no attribute "id" [union-attr]
- discord/abc.py:1793: error: Item "None" of "Snowflake | datetime | None" has no attribute "id" [union-attr]
- discord/abc.py:1797: error: Item "datetime" of "Snowflake | datetime | None" has no attribute "id" [union-attr]
- discord/abc.py:1797: error: Item "None" of "Snowflake | datetime | None" has no attribute "id" [union-attr]
hydra-zen (https://github.com/mit-ll-responsible-ai/hydra-zen)
- src/hydra_zen/structured_configs/_implementations.py:3117: error: Argument 1 to "list" has incompatible type "list[str | DataClass_ | Mapping[str, str | Sequence[str] | None]] | None"; expected "Iterable[Any]" [arg-type]
|
This was referenced Nov 5, 2023
Closed
JukkaL
pushed a commit
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4297
Fix is straightforward: without properly pushing lambda expression on the stack, the previous fix @JukkaL added for nested functions doesn't work for lambdas (it thinks that we are at global scope).