Fix crash on Callable self in __call__ #16453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: discord.py (https://github.com/Rapptz/discord.py): typechecking got 1.08x slower (148.8s -> 160.3s)
(Performance measurements are based on a single noisy sample)
|
hauntsaninja
approved these changes
Nov 10, 2023
|
I checked and this resolves the crash on my original source! thank you. |
jepler
reviewed
Nov 11, 2023
| # Having a def __call__(self: Callable[...], ...) can cause infinite recursion. Although | ||
| # this special-casing looks not very principled, there is nothing meaningful we can infer | ||
| # from such definition, since it is inherently indefinitely recursive. | ||
| allow_callable = func.name is None or not func.name.startswith("__call__ of") |
There was a problem hiding this comment.
"__call__ of" looks weird to me -- mind telling me what's going on?
There was a problem hiding this comment.
This is just how names work for methods.
JukkaL
pushed a commit
that referenced
this pull request
Nov 22, 2023
Fixes #16450 The fix is a bit ad-hoc, but OTOH there is nothing meaningful we can infer in such situation, so it is probably OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16450
The fix is a bit ad-hoc, but OTOH there is nothing meaningful we can infer in such situation, so it is probably OK.