Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid does not return error in lambda #17294

Merged
merged 1 commit into from
May 28, 2024
Merged

Avoid does not return error in lambda #17294

merged 1 commit into from
May 28, 2024

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented May 26, 2024 •
edited
Loading

Fixes #10520, fixes #15142

@hauntsaninja hauntsaninja mentioned this pull request May 26, 2024
Merged
@andersk
Copy link
Contributor

andersk commented May 26, 2024 •
edited
Loading

Could be marked as fixing

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja merged commit f60f458 into python:master May 28, 2024
17 of 18 checks passed
@hauntsaninja hauntsaninja deleted the lambda-return branch May 28, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return of NoReturn lambda doesn't propagate NoReturn behavior
3 participants
@hauntsaninja @andersk @JelleZijlstra