stubgen: add support for PEPs 695 and 696 syntax #18054
Open
+128
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamdanal
added
topic-stubgen
topic-pep-696
Comment on lines
+145
to
152
| sig = "{indent}{prefix}def {name}{type_args}({args}){ret}:".format( | ||
| indent=indent, | ||
| prefix=prefix, | ||
| name=self.name, | ||
| args=", ".join(args), | ||
| ret=retfield, | ||
| type_args=self.type_args, | ||
| ) |
There was a problem hiding this comment.
nit: while we're touching this, we could take the opportunity to switch to an f-string:
Suggested change
| sig = "{indent}{prefix}def {name}{type_args}({args}){ret}:".format( | |
| indent=indent, | |
| prefix=prefix, | |
| name=self.name, | |
| args=", ".join(args), | |
| ret=retfield, | |
| type_args=self.type_args, | |
| ) | |
| sig = f"{indent}{prefix}def {self.name}{self.type_args}({', '.join(args)}){retfield}:" |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17997