PEP 702 (@deprecated): descriptors #18090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
(`--python-version 3.9` did not help)
This comment has been minimized.
This comment has been minimized.
…ck_call_expr_with_callee_type` accordingly.
This comment has been minimized.
This comment has been minimized.
|
@ilevkivskyi: sorry to bother you again... |
ilevkivskyi
approved these changes
Dec 4, 2024
|
Please make sure to merge master. I think the tests need updating after #18192 (we need to at least enable deprecated) |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
That was fast. Thanks for reviewing and merging! |
svalentin
pushed a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatively straightforward this time. Any special cases that need additional consideration?