Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Join meet symmetric #18227

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Join meet symmetric #18227

merged 2 commits into from
Dec 2, 2024

Conversation

MechanicalConstruct
Copy link
Contributor

@MechanicalConstruct MechanicalConstruct commented Dec 1, 2024 •
edited
Loading

Fixes #18199

Updated join.py to return AnyType(TypeOfAny.special_form) for both UnboundType and AnyType.

Updated meet.py to return UninhabitedType() when visiting a UnboundType as a NoneType when state.strict_optional is true.

@MechanicalConstruct
update meet to return UninhabitedType() in the case of a None + Uninh…
f185c29 
…abited Type Meet

update join to return AnyType in the case of NoneType + AnyType
@MechanicalConstruct
update tests
66b046b
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

hauntsaninja
hauntsaninja approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@hauntsaninja hauntsaninja merged commit 1a95964 into python:master Dec 2, 2024
19 checks passed
@MechanicalConstruct MechanicalConstruct deleted the join_meet_symmetric branch December 2, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Join and meet are not symmetric
2 participants
@MechanicalConstruct @hauntsaninja