Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert/remove casts in semanal.py #2341

Merged
merged 2 commits into from
Oct 27, 2016
Merged

Assert/remove casts in semanal.py #2341

merged 2 commits into from
Oct 27, 2016

Conversation

elazarg
Copy link
Contributor

@elazarg elazarg commented Oct 27, 2016

Part of #2272

@gvanrossum gvanrossum merged commit 7b6fbb7 into python:master Oct 27, 2016
gvanrossum pushed a commit that referenced this pull request Jan 27, 2017
Fix an assert that passed type checks but could fail at runtime.
8625db7 
Fixes #2751.

(That assert was added in #2341 to force the type checker to believe
that 'file' is a MypyFile instance, but the rest of the code makes it
clear that it may also be None, in which case the assert fails.)
@gvanrossum gvanrossum mentioned this pull request Jan 27, 2017
Merged
gvanrossum added a commit that referenced this pull request Jan 27, 2017
@gvanrossum
Fix an assert that passed type checks but could fail at runtime. (#2767)
50e3fed 
Fixes #2751.

(That assert was added in #2341 to force the type checker to believe
that 'file' is a MypyFile instance, but the rest of the code makes it
clear that it may also be None, in which case the assert fails.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elazarg @gvanrossum