Fix crash with NamedTuple classmethod #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really hacky but this should work for now. I think the bug was introduced when we added support for NamedTuple classmethods. Fixes python#3317
JelleZijlstra
commented
May 4, 2017
| # attempting to type check methods may lead to crashes because NamedTuples | ||
| # do not have a fully functional TypeInfo. | ||
| # TODO remove this hack and add full support for NamedTuple methods | ||
| defn.defs.body = [stmt for stmt in defn.defs.body |
There was a problem hiding this comment.
This is safe because statements within a NamedTuple class fall in three groups (see check_namedtuple_classdef below):
- assignments, which we still type check
- pass and Ellipsis, which don't do anything and which we ignore here
- Other statements, which produce an error on line 841/847 below and now are ignored here.
|
More background: This was almost certainly introduced by #2719, which started type checking the body of a namedtuple class in order to validate default values. Now, classmethods get visited during semantic analysis, but when we try to bind their cls argument, there is no usable type info available because NamedTuples aren't really classes. This PR fixes the problem with a sledgehammer by dropping all invalid statements from the body of the NamedTuple class. |
JukkaL
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really hacky but this should work for now. I think the bug
was introduced when we added support for NamedTuple
classmethods.
Fixes #3317