Clean up last traces of 'final_value' field #6791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is a follow-up to python#6763: it renames some parameter names and variables that got missed up above. One interesting side-note: it seems like 'Var' notes also contain a `final_value` field that does almost the same thing as this `last_known_value` field, but is ultimately unrelated: it was introduced back in python#5522. I decided to leave this field alone. (I discovered this while updating mypyc and discovered (to my surprise) that nothing broke.)
|
As a tangent, the presence of this new It'd be nice if we could unify this field with the existing Literal types work, or even remove it altogether in favor of using the inferred types. But that would mean dropping support for floats/dropping support for optimizing code involving floats in mypyc, which feels bad. |
I would leave it as is for now, but in long term perspective I see a value in simplifying these things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a follow-up to #6763: it renames some parameter names and variables that got missed earlier.
One interesting side-note: it seems like 'Var' notes also contain a
final_valuefield that does almost the same thing as thislast_known_valuefield, but is ultimately unrelated: it was introduced back in #5522. I decided to leave this field alone.(I discovered this while updating mypyc and discovered (to my surprise) that nothing broke.)