Renable flake8 warning about getattr with constant string #6848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypy/fscache.py
Outdated
| @@ -146,7 +146,7 @@ def _fake_init(self, path: str) -> os.stat_result: | |||
| tpl = tuple(seq) | |||
| # FIXME: this works around typeshed claiming stat_result is from posix | |||
| # (typeshed #2683) | |||
| st = getattr(os, 'stat_result')(tpl) | |||
| st = getattr(os, 'stat_result')(tpl) # noqa | |||
There was a problem hiding this comment.
python/typeshed#2683 was merged, so seems like this can just use os.stat_result?
In general I would have preferred for this to use # type: ignore, which is more greppable, and that way a run with --warn-unused-ignores could have found that this hack is no longer needed.
There was a problem hiding this comment.
Fixed. It was working around an issue that showed up in mypyc, not in mypy, so the getattr was needed for annoying reasons.
gvanrossum
approved these changes
May 20, 2019
| @@ -700,7 +700,7 @@ def add_invertible_flag(flag: str, | |||
|
|
|||
| # Set strict flags before parsing (if strict mode enabled), so other command | |||
| # line options can override. | |||
| if getattr(dummy, 'special-opts:strict'): | |||
| if getattr(dummy, 'special-opts:strict'): # noqa | |||
There was a problem hiding this comment.
Curious that this requires a # noqa -- apparently flake8 doesn't realize that the literal string is not a valid identifier. :-)
| @@ -78,11 +78,11 @@ def get_edges(o: object) -> Iterator[Tuple[object, object]]: | |||
| # in closures and self pointers to other objects | |||
|
|
|||
| if hasattr(e, '__closure__'): | |||
| yield (s, '__closure__'), getattr(e, '__closure__') | |||
| yield (s, '__closure__'), e.__closure__ # type: ignore | |||
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the
getattrcalls with constant strings were to shut up mypy, so add a bunch of# type: ignores for those.A couple were for other things (something dumb with mypyc, using an invalid identifier),
so those get
# noqa.Not totally sure if this is actually better, which is why I didn't put the PR up when I first wrote it,
but pushing now to see what other people think so I can clean up the branch.
(I'm leaning towards it being better, but only marginally.)