Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generic class variables #7906

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

ilevkivskyi
Copy link
Member

The existing check is overly strict, because we already have a check at the use site. Also this makes instance variables, class variables and class methods more consistent/homogeneous.

(I will merge as soon as tests pass, since this PR is small and it blocks #7885)

@ilevkivskyi ilevkivskyi merged commit 834efe4 into python:master Nov 8, 2019
@ilevkivskyi ilevkivskyi deleted the tweak-generic-classvar branch November 8, 2019 16:11
svalentin added a commit that referenced this pull request Nov 14, 2022
improve ast types; revert several "redundant numeric union" changes from #7906
see python/typeshed#9130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant