PEP 566: Fix keywords delimiter in JSON conversion #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
approved these changes
Feb 14, 2023
CAM-Gerlach
reviewed
Feb 15, 2023
There was a problem hiding this comment.
To note, this wasn't ported over to the canonical PyPA core metadata spec (which appears to be deliberate, as mentioned there:
Although PEP 566 defined a way to transform metadata into a JSON-compatible dictionary, this is not yet used as a standard interchange format. The need for tools to work with years worth of existing packages makes it difficult to shift to a new format.
So, I guess it doesn't hurt to fix this here (even though it's not totally clear if its still canonical)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the spec to better match reality rather than attempting to do the opposite.
Ref: https://packaging.python.org/en/latest/specifications/core-metadata/#keywords
Ref: pypa/packaging#570 (comment)