Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 655: Mark as Final #3672

Merged
merged 3 commits into from
Feb 16, 2024
Merged

PEP 655: Mark as Final #3672

merged 3 commits into from
Feb 16, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 15, 2024 •
edited by github-actions bot
Loading

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

Helps #3579 and #2872.

Also add green/yellow/red sidebars for the yes/okay/no codeblocks, similar to PEP 8:

image

📚 Documentation preview 📚: https://pep-previews--3672.org.readthedocs.build/

@hugovk hugovk mentioned this pull request Feb 15, 2024
Closed
16 tasks
@hugovk hugovk merged commit 467e5b5 into python:main Feb 16, 2024
6 checks passed
@hugovk hugovk deleted the pep655-mark-as-final branch February 16, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @JelleZijlstra