Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requests.packages missing in types-requests 2.27.5 #6893

Closed
wpwood opened this issue Jan 11, 2022 · 7 comments
Closed

requests.packages missing in types-requests 2.27.5 #6893

wpwood opened this issue Jan 11, 2022 · 7 comments

Comments

@wpwood
Copy link

wpwood commented Jan 11, 2022

When moving from types-requests 2.26.3 to 2.27.5, the following code

requests.packages.urllib3.disable_warnings(requests.packages.urllib3.exceptions.InsecureRequestWarning)

now gets a type error in mypy, error: Module has no attribute "packages"

I was able to fix the issuing by forcing mypy to use types-requests 2.26.3.
@JelleZijlstra JelleZijlstra mentioned this issue Jan 11, 2022
Closed
@JelleZijlstra
Copy link
Member

We removed it in #6859. That PR doesn't make clear why the copy in requests was removed; it seems to still exist in the most recent release of requests.

@wpwood
Copy link
Author

wpwood commented Jan 11, 2022

We removed it in #6859. That PR doesn't make clear why the copy in requests was removed; it seems to still exist in the most recent release of requests.

Yeah, that was what I saw as well, that it still seems to be in requests.

@srittau
Copy link
Collaborator

srittau commented Jan 11, 2022

The original plan was to import the urllib3 stubs from types-urllib3 into requests.packages.urllib3 as runtime does. Unfortunately, this isn't easily possible. The requests.packages.urllib3 were quite outdated, and it's not clear which version of urllib3 we should use. It would also mean that we have to maintain two copies of urllib3. I recommend to import urllib3 imports directly from urllib3 instead of requests.packages.urllib3.

@Akuli
Copy link
Collaborator

Akuli commented Jan 12, 2022

The code example in this issue needs the same copy of urllib3 as requests uses internally, because it is suppressing a warning that requests generates while it is using its urllib3. I think we should add back requests/packages/__init__.pyi with a __getattr__ incomplete marker, so that the import will at least work, even if it isn't very nicely type checked.

@srittau
Copy link
Collaborator

srittau commented Jan 12, 2022

The __getattr__() marker is a good idea. The alternative is (your idea, I think) to basically copy the urllib3 structure and do a from urllib.xyz import * in each file, although I'd like to avoid that.

@andersk
Copy link
Contributor

andersk commented Jan 13, 2022 •
edited
Loading

requests no longer vendors urllib3 or any other packages as of 2.16.0 (psf/requests#4067), so there’s no longer a concern as to which version to use.

>>> import urllib3, requests.packages.urllib3
>>> requests.packages.urllib3 is urllib3
True

@parthea parthea mentioned this issue Jan 15, 2022
Merged
peterschutt added a commit to peterschutt/djangorestframework-stubs that referenced this issue Jan 23, 2022
@peterschutt
Import urllib3 directly.
3ee14ec 
types-requests removed urllib3 stubs and [have recommended](python/typeshed#6893 (comment))
to use types-urllib3 directly.
benesch added a commit to benesch/mypy_boto3_builder that referenced this issue Jan 23, 2022
@benesch
Use dedicated urllib3 type stubs
3ddf3a7 
See python/typeshed#6893. The `request.packages.urllib3` module no
longer has type stubs, but there are dedicated type stubs for `urllib3`
that can be used instead.
@benesch benesch mentioned this issue Jan 23, 2022
Merged
eggplants added a commit to akamhy/waybackpy that referenced this issue Feb 4, 2022
@eggplants
Typing (#128)
d8cabdf 
* fix: CI yml name

* add: mypy configuraion

* add: type annotation to waybackpy modules

* add: type annotation to test modules

* fix: mypy command

* add: types-requests to dev deps

* fix: disable max-line-length

* fix: move pytest.ini into setup.cfg

* add: urllib3 to deps

* fix: Retry (ref: python/typeshed#6893)

* fix: f-string

* fix: shorten long lines

* add: staticmethod decorator to no-self-use methods

* fix: str(headers)->headers_str

* fix: error message

* fix: revert "str(headers)->headers_str" and ignore assignment CaseInsensitiveDict with str

* fix: mypy error
@srittau
Copy link
Collaborator

srittau commented Jul 12, 2022

Closing per @andersk's comment.

@srittau srittau closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2022
JAK0723 added a commit to JAK0723/Twitch-Chat-Downloader that referenced this issue Dec 31, 2022
@JAK0723
Change urllib3 import to a top-level import and explicitly add urllib…
0128fef 
…3 to requirements.txt

Relevant issues:
https://youtrack.jetbrains.com/issue/PY-53895
python/typeshed#6893
https://stackoverflow.com/a/68281646
@JAK0723 JAK0723 mentioned this issue Dec 31, 2022
Merged
TheDrHax pushed a commit to TheDrHax/Twitch-Chat-Downloader that referenced this issue Dec 31, 2022
@JAK0723 @TheDrHax
Change urllib3 import to a top-level import and explicitly add urllib…
50a0f28 
…3 to requirements.txt

Relevant issues:
https://youtrack.jetbrains.com/issue/PY-53895
python/typeshed#6893
https://stackoverflow.com/a/68281646
@mcdonnnj mcdonnnj mentioned this issue Feb 13, 2023
Merged
1 task
@mesozoic mesozoic mentioned this issue Apr 7, 2023
Merged
@bmw bmw mentioned this issue Oct 18, 2023
Merged
beliaev-maksim added a commit to beliaev-maksim/responses that referenced this issue Oct 20, 2023
@beliaev-maksim
remove dependency on urllib3 vendored in requests since it is not mai…
ca94676 
…ntained anymore. See python/typeshed#6893 (comment)
@beliaev-maksim beliaev-maksim mentioned this issue Oct 20, 2023
Merged
markstory pushed a commit to getsentry/responses that referenced this issue Oct 21, 2023
@beliaev-maksim
fix types (#684)
74466ec 
* remove dependency on urllib3 vendored in requests since it is not maintained anymore. See python/typeshed#6893 (comment)
* new version of mypy does not require overloads for type checking
* [skip] remove pragma comment
btbrand added a commit to btbrand/responses that referenced this issue Apr 22, 2024
@btbrand
fix types (#684)
8640a38 
* remove dependency on urllib3 vendored in requests since it is not maintained anymore. See python/typeshed#6893 (comment)
* new version of mypy does not require overloads for type checking
* [skip] remove pragma comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@andersk @srittau @JelleZijlstra @wpwood @Akuli