Revert "Bump jsonschema to 4.19.*" #10773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6ca7505.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
I don't think this is a good idea. I'm not sure the stub uploader will handle this case gracefully. |
Ah. Well, you know better than me when it comes to that. What will the stub-uploader do if we yank v4.19.0.0 without doing this revert? Will it simply stop pushing new versions to PyPI for the time being, or will it push v4.19.0.0 again? |
|
I'll just merge the changes to the stub uploader and kick off a new release of types-jsonschema. Then we should be safe. |
|
Okay, great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10583. See #10772: the PR makes
types-jsonschemaincompatible with Python 3.7, sincetypes-jsonschemanow depends on thereferencinglibrary, which requires Python 3.8+ (but didn't state as much in itssetup.py/pyproject.tomlin early versions released to PyPI).We should be able to revert the revert once typeshed-internal/stub_uploader#103 is merged, which will allow us to properly declare that the stubs package requires Python 3.8+.