Use _typeshed.Self where __enter__ returns self #5698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a start on annotating
__enter__
methods asdef __enter__(self: Self) -> Self: ...
where the method just returns the class instance (self
)The current annotations assume that the
__enter__
method on subclasses returns an instance of the parent class.There are more than these, but they are either more complicated or are already annotated as
def __enter__(self: _T) -> _T: ...
This is a step towards #5676, and is related to #5675 and #5602