Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __note__ to BaseException in Python 3.11 #6633

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

@AlexWaygood
Copy link
Member

AlexWaygood commented Dec 20, 2021

It seems like the Steering Council hasn't formally signed off on this addition yet -- might it be worth waiting until the change is confirmed? python/peps#2201

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@lancelote
Copy link
Contributor Author

lancelote commented Dec 20, 2021

Ah, I see, thanks. The change is available in 3.11.0a3, so I thought it was already approved.

@JelleZijlstra
Copy link
Member

Since it's currently in 3.11, I say we put it in; it's easy to remove it later if the PEP gets rejected.

@JelleZijlstra JelleZijlstra merged commit b1b958d into python:master Dec 20, 2021
@lancelote lancelote deleted the dunder-note branch December 20, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants