Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stubs for netaddr #9431

Merged
merged 4 commits into from
Jan 7, 2023
Merged

Add stubs for netaddr #9431

merged 4 commits into from
Jan 7, 2023

Conversation

hamdanal
Copy link
Contributor

@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed Jan 5, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a partial review. I haven't read past netaddr/eui/__init__.pyi yet.

stubs/netaddr/netaddr/core.pyi Outdated Show resolved Hide resolved
stubs/netaddr/netaddr/eui/__init__.pyi Outdated Show resolved Hide resolved
stubs/netaddr/netaddr/eui/__init__.pyi Show resolved Hide resolved
stubs/netaddr/netaddr/eui/__init__.pyi Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood reviewed Jan 5, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the rest of my review -- a few more comments, but mostly fairly minor. This is a very high-quality PR -- thank you!

stubs/netaddr/netaddr/eui/ieee.pyi Outdated Show resolved Hide resolved
stubs/netaddr/netaddr/ip/__init__.pyi Outdated Show resolved Hide resolved
stubs/netaddr/netaddr/ip/__init__.pyi Outdated Show resolved Hide resolved
stubs/netaddr/netaddr/ip/__init__.pyi Outdated Show resolved Hide resolved
stubs/netaddr/netaddr/ip/__init__.pyi Outdated Show resolved Hide resolved
stubs/netaddr/netaddr/strategy/eui48.pyi Outdated Show resolved Hide resolved
stubs/netaddr/netaddr/strategy/eui64.pyi Outdated Show resolved Hide resolved
stubs/netaddr/netaddr/strategy/eui64.pyi Outdated Show resolved Hide resolved
stubs/netaddr/netaddr/strategy/ipv6.pyi Outdated Show resolved Hide resolved
stubs/netaddr/netaddr/strategy/ipv6.pyi Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
hamdanal and others added 2 commits January 7, 2023 17:03
@hamdanal @AlexWaygood
Remove restriction on file
95c1007 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@hamdanal
Make valid_glob a type guard
1adc327
AlexWaygood
AlexWaygood approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 7, 2023 •
edited
Loading

Thank you for rich-argparse as well, by the way -- I'm using it in one of my projects, and it's very nice :)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 2c9816e into python:main Jan 7, 2023
@hamdanal hamdanal deleted the netaddr branch January 7, 2023 16:24
@hamdanal
Copy link
Contributor Author

hamdanal commented Jan 7, 2023

Thanks Alex for all your contributions, helpful as always.

P.S: Today you get stability with rich-argparse, I just released 1.0. 🚀

@Avasam Avasam mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamdanal @AlexWaygood