-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an anti-pitch for typing #1477
Conversation
@pfmoore Would the existence of this document help you? I've tried to represent things as fairly as possible, but I'm in quite deep and might be biased :-) Do you have any feedback? |
8140b49
to
4ba81ec
Compare
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this seems good, and sufficiently balanced.
It still puts the onus on the library author to justify their choice to not use typing (even if it’s just to the extent of linking to this) - that’s the social side of the problem, though, and documentation won’t fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes a lot of sense. This feels a bit like the You Might Not Need Redux article by the original author of Redux. A few general notes:
- Stylistic nit: I would lose the parentheses when discussing counterpoints. These are valid arguments and not just asides.
- While it's okay for now, I think putting this document into an "FAQ" section would be a better fit than the "Guides" section.
Co-authored-by: Erik De Bonte <erikd@microsoft.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Thanks all! I think I got all the feedback; feel free to open a PR if there's something I missed :-) |
No description provided.