[spec] Update typeshed language to conform to reality #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
srittau
commented
Jan 10, 2024
srittau
commented
- Describe typeshed as a "project", not a "repository".
- While typeshed still contains third-party stubs, those are usually not distributed with type checkers, but available from PyPI. Update the language accordingly.
- This also means that step 5 of the import resolution ordering should reference the stdlib only.
- Fix the reference to another section.
- Fix typo in section name.
* Describe typeshed as a "project", not a "repository". * While typeshed still contains third-party stubs, those are usually not distributed with type checkers, but available from PyPI. Update the language accordingly. * This also means that step 5 of the import resolution ordering should reference the stdlib only. * Fix the reference to another section. * Fix typo in section name.
srittau
added
the
Typing Council decision
erictraut
approved these changes
Jan 10, 2024
JelleZijlstra
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Thanks! Let's leave this open for a few days in case other Council members have a different opinion (cc @hauntsaninja @gvanrossum @rchen152), but I don't think this needs to go through the formal decision-making procedure.
There is one typeshed-related issue that maybe we should add to the spec: the format of the VERSIONS file. I think that's important to specify because it affects type checker interoperability. However, that should be discussed separately.
rchen152
approved these changes
Jan 10, 2024
hauntsaninja
approved these changes
Jan 12, 2024
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
hauntsaninja
added a commit
to hauntsaninja/typing
that referenced
this pull request
Jan 16, 2024
* Describe typeshed as a "project", not a "repository". * While typeshed still contains third-party stubs, those are usually not distributed with type checkers, but available from PyPI. Update the language accordingly. * This also means that step 5 of the import resolution ordering should reference the stdlib only. Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.