Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix _GenericAlias import #871

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

JelleZijlstra
Copy link
Member

TypeGuard was broken in 3.9 because we weren't importing _GenericAlias in some versions after #868. I'm still working on testing other versions using pyenv locally.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass locally.

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging this out!

@JelleZijlstra JelleZijlstra merged commit af13555 into python:master Aug 30, 2021
@JelleZijlstra JelleZijlstra deleted the genal branch August 30, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants